Fix: too many otp requests when deleting user and re-registering

admin.php

@@ -139,7 +139,7 @@ if ($user_id === 0) {
 $pdo = db_connect();
 
 // Prevent admin from acting on themselves
-$stmt = $pdo->prepare('SELECT username FROM users WHERE id = :id LIMIT 1');
+$stmt = $pdo->prepare('SELECT username, email FROM users WHERE id = :id LIMIT 1');
 $stmt->execute([':id' => $user_id]);
 $target = $stmt->fetch();
 if (!$target) {
@@ -202,6 +202,12 @@ if ($action === 'delete_user') {
 
     $pdo->prepare('DELETE FROM users WHERE id = :id')
         ->execute([':id' => $user_id]);
+
+    // Clear OTP history for this email so re-signing-up doesn't hit the
+    // daily OTP request limit because of OTPs sent before deletion.
+    $pdo->prepare('DELETE FROM email_otps WHERE email = :e')
+        ->execute([':e' => $target['email']]);
+
     json_out(['success' => true]);
 }
 

auth.php

@@ -528,14 +528,14 @@ if ($action === 'signup') {
 
     $welcome_message =
         "Hi {$username},\n\n" .
-        "Welcome aboard!\n\n" .
-        "Thank you for signing up.\n\n" .
-        "Your credentials for services:\n\n" .
-        "XMPP JID: {$xmpp_username}@freedoms4.org\n" .
+        "Welcome aboard, thank you for signing up!\n\n" .
+        "Your credentials for the services:\n\n" .
         "Email ID: {$username}@freedoms4.org\n" .
+        "XMPP JID: {$xmpp_username}@freedoms4.org\n" .
         "Passwords: Use the same password that you used during registration.\n\n" .
         "If you have any questions, I'm here to help:\n" .
-        "Email <mailto:hyzen@freedoms4.org> and XMPP <xmpp:hyzen@freedoms4.org>: hyzen@freedoms4.org\n" .
+	"Email: mailto:hyzen@freedoms4.org\n".
+	"XMPP: xmpp:hyzen@freedoms4.org\n" .
         "IRC/Liberachat: hyzen, #freedoms4\n\n" .
         "Best regards,\n" .
         "hyzen, freedoms4.org.";